mirror of
https://github.com/pre-commit/pre-commit.git
synced 2026-02-17 08:14:42 +04:00
466f6c4a39
By running containers in a rootless docker context as root. This is because user and group IDs are remapped in the user namespaces uses by rootless docker, and it's unlikely that the current user ID will map to the same ID under this remap (see docs[1] for some more details). Specifically, it means ownership of mounted volumes will not be for the current user and trying to write can result in permission errors. This change borrows heavily from an existing PR[2]. The output format of `docker system info` I don't think is documented/guaranteed anywhere, but it should corresponding to the format of a `/info` API request to Docker[3] The added test _hopes_ to avoid regressions in this behaviour, but since tests aren't run in a rootless docker context on the PR checks (and I couldn't find an easy way to make it the case) there's still a risk of regressions sneaking in. Link: https://docs.docker.com/engine/security/rootless/ [1] Link: https://github.com/pre-commit/pre-commit/pull/1484/ [2] Link: https://docs.docker.com/reference/api/engine/version/v1.48/#tag/System/operation/SystemAuth [3] Co-authored-by: Kurt von Laven <Kurt-von-Laven@users.noreply.github.com> Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| conda_test.py | ||
| coursier_test.py | ||
| dart_test.py | ||
| docker_image_test.py | ||
| docker_test.py | ||
| dotnet_test.py | ||
| fail_test.py | ||
| golang_test.py | ||
| haskell_test.py | ||
| julia_test.py | ||
| lua_test.py | ||
| node_test.py | ||
| perl_test.py | ||
| pygrep_test.py | ||
| python_test.py | ||
| r_test.py | ||
| ruby_test.py | ||
| rust_test.py | ||
| script_test.py | ||
| swift_test.py | ||
| system_test.py | ||