mirror of
https://github.com/pre-commit/pre-commit.git
synced 2026-04-16 02:21:46 +04:00
29d66f470d
Adds a test for python and bash `types` using identify per interpreter interpretation. The python test succeeds with a false positive. The bash test identifies the bug, where a comparison happens between `tags >= types`. Tags is the tag list from identify, types is the value passed in from configuration file as `acceptable types`. The `tags(List) >= types(FrozenSet)` does a sort comparison of the two sequences as evidenced by this code sample (which should return True): ``` >>> types = frozenset(['a']) >>> tags = ['bash'] >>> tags >= types True ``` Note: In 2.7, I cannot get this to return anything other than True. Including the empty case: ``` >>> [] > frozenset() True ``` Which means to me that a list is always >= a frozenset in Python 2.7. In Python 3.5, I see errors when comparing a List to a FrozenSet. So thankfully the interpreter is stricter in this case. ``` >>> [] >= frozenset() TypeError: unorderable types: list() >= frozenset() ``` |
||
|---|---|---|
| .. | ||
| commands | ||
| languages | ||
| meta_hooks | ||
| __init__.py | ||
| clientlib_test.py | ||
| color_test.py | ||
| conftest.py | ||
| envcontext_test.py | ||
| error_handler_test.py | ||
| git_test.py | ||
| logging_handler_test.py | ||
| main_test.py | ||
| make_archives_test.py | ||
| output_test.py | ||
| parse_shebang_test.py | ||
| prefix_test.py | ||
| repository_test.py | ||
| runner_test.py | ||
| staged_files_only_test.py | ||
| store_test.py | ||
| util_test.py | ||
| xargs_test.py | ||