Commit graph

12 commits

Author SHA1 Message Date
Sharmila Jesupaul
9581ffc148 wrap long pygrep test line 2026-02-18 18:14:59 -08:00
Sharmila Jesupaul
635912514d add pass_filenames_via_stdin for large changesets
pre-commit currently passes selected filenames to hooks via argv.
For large changesets (or --all-files), argv length limits are hit and
filenames are partitioned, causing multiple hook invocations.

This means there is currently no built-in way to pass filenames to an
underlying hook in one shot without chunking / re-running. The only practical
workaround is to set pass_filenames: false and run custom git operations in
hook code to reconstruct the file set, which is expensive and duplicates
pre-commit's own file-selection logic.

This change adds a hook option:

    pass_filenames_via_stdin: true

When enabled, pre-commit sends filenames as NUL-delimited bytes on stdin and
runs the hook in a single invocation (no argv chunking).

Why NUL-delimited stdin:
- safe for filenames containing spaces/newlines
- matches established -0 conventions in unix tooling

Usage for hook authors:
- shell:

    while IFS= read -r -d '' filename; do
        ...
    done

- python:

    data = sys.stdin.buffer.read()
    filenames = [os.fsdecode(p) for p in data.split(b'\0') if p]

Behavior notes:
- default remains argv-based passing
- pass_filenames: false still disables filename passing entirely

Implementation includes schema/runtime wiring, shared NUL encode/decode
helpers, and tests covering defaulting and runtime behavior.
2026-02-18 18:06:34 -08:00
marsha
a2373d0a81 test pygrep inline 2023-02-18 17:54:44 -05:00
Anthony Sottile
04de6a2e57 drop python 3.6 support
python 3.6 reached end of life on 2021-12-23
2022-01-18 18:44:20 -05:00
Marco Gorelli
a0658c06bf add --negate flag to pygrep 2020-10-17 18:50:40 +01:00
Marco Gorelli
2fc676709d Remove unnecessary fixtures in signatures from pygrep tests 2020-10-16 13:11:18 -07:00
Anthony Sottile
30c1e8289f upgrade hooks, pyupgrade pre-commit 2020-01-12 09:27:04 -08:00
Thierry Deo
55c74c10d9 Rename option to and improve output 2018-03-08 09:42:32 +01:00
Thierry Deo
25c06e6525 Remove encoding dependence 2018-03-07 09:24:56 +01:00
Thierry Deo
3793bc32c0 Fix linters 2018-02-26 15:46:33 +01:00
Thierry Deo
69333fa227 Add multiline mode to pygrep 2018-02-26 10:17:21 +01:00
Anthony Sottile
e9509306d8 Implement pygrep language as a replacement for pcre 2017-09-22 22:31:30 -07:00