third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #652 from pre-commit/remove_slowtests

Browse source 
Remove slowtests=false setting
This commit is contained in:
Anthony Sottile 2017-11-02 17:54:57 -05:00 • committed by GitHub
commit f098ec30b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 0 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CONTRIBUTING.md
View file

@ -39,9 +39,6 @@ Alternatively, with the environment activated you can run all of the tests
using: using:
`py.test tests` `py.test tests`
To skip the slower ruby / node integration tests, you can set the environment
variable `slowtests=false`.
### Setting up the hooks ### Setting up the hooks
With the environment activated simply run `pre-commit install`. With the environment activated simply run `pre-commit install`.

5
testing/util.py
View file

@ -32,11 +32,6 @@ skipif_cant_run_docker = pytest.mark.skipif(
reason='Docker isn\'t running or can\'t be accessed', reason='Docker isn\'t running or can\'t be accessed',
) )
skipif_slowtests_false = pytest.mark.skipif(
os.environ.get('slowtests') == 'false',
reason='slowtests=false',
)
skipif_cant_run_swift = pytest.mark.skipif( skipif_cant_run_swift = pytest.mark.skipif(
parse_shebang.find_executable('swift') is None, parse_shebang.find_executable('swift') is None,
reason='swift isn\'t installed or can\'t be found', reason='swift isn\'t installed or can\'t be found',

2
tests/make_archives_test.py
View file

@ -11,7 +11,6 @@ from pre_commit import make_archives
from pre_commit.util import cmd_output from pre_commit.util import cmd_output
from pre_commit.util import cwd from pre_commit.util import cwd
from testing.fixtures import git_dir from testing.fixtures import git_dir
from testing.util import skipif_slowtests_false
def test_make_archive(tempdir_factory): def test_make_archive(tempdir_factory):
@ -50,7 +49,6 @@ def test_make_archive(tempdir_factory):
assert not os.path.exists(os.path.join(extract_dir, 'foo', 'bar')) assert not os.path.exists(os.path.join(extract_dir, 'foo', 'bar'))
@skipif_slowtests_false
@pytest.mark.integration @pytest.mark.integration
def test_main(tmpdir): def test_main(tmpdir):
make_archives.main(('--dest', tmpdir.strpath)) make_archives.main(('--dest', tmpdir.strpath))

12
tests/repository_test.py
View file

@ -31,7 +31,6 @@ from testing.fixtures import modify_manifest
from testing.util import get_resource_path from testing.util import get_resource_path
from testing.util import skipif_cant_run_docker from testing.util import skipif_cant_run_docker
from testing.util import skipif_cant_run_swift from testing.util import skipif_cant_run_swift
from testing.util import skipif_slowtests_false
from testing.util import xfailif_no_pcre_support from testing.util import xfailif_no_pcre_support
from testing.util import xfailif_windows_no_node from testing.util import xfailif_windows_no_node
from testing.util import xfailif_windows_no_ruby from testing.util import xfailif_windows_no_ruby
@ -145,7 +144,6 @@ def test_versioned_python_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@skipif_cant_run_docker @skipif_cant_run_docker
@pytest.mark.integration @pytest.mark.integration
def test_run_a_docker_hook(tempdir_factory, store): def test_run_a_docker_hook(tempdir_factory, store):
@ -156,7 +154,6 @@ def test_run_a_docker_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@skipif_cant_run_docker @skipif_cant_run_docker
@pytest.mark.integration @pytest.mark.integration
def test_run_a_docker_hook_with_entry_args(tempdir_factory, store): def test_run_a_docker_hook_with_entry_args(tempdir_factory, store):
@ -167,7 +164,6 @@ def test_run_a_docker_hook_with_entry_args(tempdir_factory, store):
) )
@skipif_slowtests_false
@skipif_cant_run_docker @skipif_cant_run_docker
@pytest.mark.integration @pytest.mark.integration
def test_run_a_failing_docker_hook(tempdir_factory, store): def test_run_a_failing_docker_hook(tempdir_factory, store):
@ -179,7 +175,6 @@ def test_run_a_failing_docker_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@skipif_cant_run_docker @skipif_cant_run_docker
@pytest.mark.integration @pytest.mark.integration
@pytest.mark.parametrize('hook_id', ('echo-entrypoint', 'echo-cmd')) @pytest.mark.parametrize('hook_id', ('echo-entrypoint', 'echo-cmd'))
@ -191,7 +186,6 @@ def test_run_a_docker_image_hook(tempdir_factory, store, hook_id):
) )
@skipif_slowtests_false
@xfailif_windows_no_node @xfailif_windows_no_node
@pytest.mark.integration @pytest.mark.integration
def test_run_a_node_hook(tempdir_factory, store): def test_run_a_node_hook(tempdir_factory, store):
@ -201,7 +195,6 @@ def test_run_a_node_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@xfailif_windows_no_node @xfailif_windows_no_node
@pytest.mark.integration @pytest.mark.integration
def test_run_versioned_node_hook(tempdir_factory, store): def test_run_versioned_node_hook(tempdir_factory, store):
@ -211,7 +204,6 @@ def test_run_versioned_node_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@xfailif_windows_no_ruby @xfailif_windows_no_ruby
@pytest.mark.integration @pytest.mark.integration
def test_run_a_ruby_hook(tempdir_factory, store): def test_run_a_ruby_hook(tempdir_factory, store):
@ -221,7 +213,6 @@ def test_run_a_ruby_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@xfailif_windows_no_ruby @xfailif_windows_no_ruby
@pytest.mark.integration @pytest.mark.integration
def test_run_versioned_ruby_hook(tempdir_factory, store): def test_run_versioned_ruby_hook(tempdir_factory, store):
@ -233,7 +224,6 @@ def test_run_versioned_ruby_hook(tempdir_factory, store):
) )
@skipif_slowtests_false
@xfailif_windows_no_ruby @xfailif_windows_no_ruby
@pytest.mark.integration @pytest.mark.integration
def test_run_ruby_hook_with_disable_shared_gems( def test_run_ruby_hook_with_disable_shared_gems(
@ -499,7 +489,6 @@ def test_additional_dependencies_roll_forward(tempdir_factory, store):
assert 'mccabe' in output assert 'mccabe' in output
@skipif_slowtests_false
@xfailif_windows_no_ruby @xfailif_windows_no_ruby
@pytest.mark.integration @pytest.mark.integration
def test_additional_ruby_dependencies_installed( def test_additional_ruby_dependencies_installed(
@ -516,7 +505,6 @@ def test_additional_ruby_dependencies_installed(
assert 'tins' in output assert 'tins' in output
@skipif_slowtests_false
@xfailif_windows_no_node @xfailif_windows_no_node
@pytest.mark.integration @pytest.mark.integration
def test_additional_node_dependencies_installed( def test_additional_node_dependencies_installed(