Simplify Repository.cmd_runner

This commit is contained in:
Anthony Sottile 2014-05-02 22:47:23 -07:00
parent f9db2b5b06
commit c5cbd473c7
4 changed files with 24 additions and 46 deletions

View file

@ -43,47 +43,38 @@ class Repository(object):
def manifest(self):
return Manifest(self.repo_path_getter)
def get_cmd_runner(self, hooks_cmd_runner):
# TODO: this effectively throws away the original cmd runner
return PrefixedCommandRunner.from_command_runner(
hooks_cmd_runner, self.repo_path_getter.repo_path,
)
@cached_property
def cmd_runner(self):
return PrefixedCommandRunner(self.repo_path_getter.repo_path)
def require_installed(self, cmd_runner):
def require_installed(self):
if self.__installed:
return
self.install(cmd_runner)
self.install()
self.__installed = True
def install(self, cmd_runner):
"""Install the hook repository.
Args:
cmd_runner - A `PrefixedCommandRunner` bound to the hooks workspace
"""
repo_cmd_runner = self.get_cmd_runner(cmd_runner)
def install(self):
"""Install the hook repository."""
for language_name in self.languages:
language = languages[language_name]
if (
language.ENVIRONMENT_DIR is None or
repo_cmd_runner.exists(language.ENVIRONMENT_DIR)
self.cmd_runner.exists(language.ENVIRONMENT_DIR)
):
# The language is already installed
continue
language.install_environment(repo_cmd_runner)
language.install_environment(self.cmd_runner)
def run_hook(self, cmd_runner, hook_id, file_args):
def run_hook(self, hook_id, file_args):
"""Run a hook.
Args:
cmd_runner - A `PrefixedCommandRunner` bound to the hooks workspace
hook_id - Id of the hook
file_args - List of files to run
"""
self.require_installed(cmd_runner)
repo_cmd_runner = self.get_cmd_runner(cmd_runner)
self.require_installed()
hook = self.hooks[hook_id]
return languages[hook['language']].run_hook(
repo_cmd_runner, hook, file_args,
self.cmd_runner, hook, file_args,
)