third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 00:04:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2740 from pre-commit/gem-file-bleh

Browse source 
Revert "also ignore Gemfile in project"
This commit is contained in:
Anthony Sottile 2023-02-01 18:19:39 -05:00 • committed by GitHub
commit bfe1a72734
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
pre_commit/languages/ruby.py
View file

@ -39,7 +39,6 @@ def get_env_patch(
('GEM_HOME', os.path.join(venv, 'gems')),
('GEM_PATH', UNSET),
('BUNDLE_IGNORE_CONFIG', '1'),
('BUNDLE_GEMFILE', os.devnull),
)
if language_version == 'system':
patches += (

7
tests/languages/ruby_test.py
View file

@ -123,8 +123,9 @@ def test_ruby_hook_language_version(tmp_path):
def test_ruby_with_bundle_disable_shared_gems(tmp_path):
workdir = tmp_path.joinpath('workdir')
workdir.mkdir()
# this Gemfile is missing `source`
workdir.joinpath('Gemfile').write_text('gem "lol_hai"\n')
# this needs a `source` or there's a deprecation warning
# silencing this with `BUNDLE_GEMFILE` breaks some tools (#2739)
workdir.joinpath('Gemfile').write_text('source ""\ngem "lol_hai"\n')
# this bundle config causes things to be written elsewhere
bundle = workdir.joinpath('.bundle')
bundle.mkdir()
@ -134,5 +135,5 @@ def test_ruby_with_bundle_disable_shared_gems(tmp_path):
)
with cwd(workdir):
# `3.2.0` has new enough `gem` requiring `source` and reading `.bundle`
# `3.2.0` has new enough `gem` reading `.bundle`
test_ruby_hook_language_version(tmp_path)