third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Restore git 1.8 support

Browse source
This commit is contained in:
Anthony Sottile 2018-03-12 13:09:05 -07:00
parent 179f11bdce
commit 96e9d1b758
10 changed files with 35 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

3
latest-git.sh
View file

@ -3,6 +3,5 @@
set -ex set -ex
git clone git://github.com/git/git --depth 1 /tmp/git git clone git://github.com/git/git --depth 1 /tmp/git
pushd /tmp/git pushd /tmp/git
make prefix=/tmp/git -j 8 all make prefix=/tmp/git -j8 install
make prefix=/tmp/git install
popd popd

10
pre_commit/commands/autoupdate.py
View file

@ -34,17 +34,17 @@ def _update_repo(repo_config, runner, tags_only):
""" """
repo_path = runner.store.clone(repo_config['repo'], repo_config['rev']) repo_path = runner.store.clone(repo_config['repo'], repo_config['rev'])
cmd_output('git', '-C', repo_path, 'fetch') cmd_output('git', 'fetch', cwd=repo_path)
tag_cmd = ('git', '-C', repo_path, 'describe', 'origin/master', '--tags') tag_cmd = ('git', 'describe', 'origin/master', '--tags')
if tags_only: if tags_only:
tag_cmd += ('--abbrev=0',) tag_cmd += ('--abbrev=0',)
else: else:
tag_cmd += ('--exact',) tag_cmd += ('--exact',)
try: try:
rev = cmd_output(*tag_cmd)[1].strip() rev = cmd_output(*tag_cmd, cwd=repo_path)[1].strip()
except CalledProcessError: except CalledProcessError:
tag_cmd = ('git', '-C', repo_path, 'rev-parse', 'origin/master') tag_cmd = ('git', 'rev-parse', 'origin/master')
rev = cmd_output(*tag_cmd)[1].strip() rev = cmd_output(*tag_cmd, cwd=repo_path)[1].strip()
# Don't bother trying to update if our rev is the same # Don't bother trying to update if our rev is the same
if rev == repo_config['rev']: if rev == repo_config['rev']:

2
pre_commit/make_archives.py
View file

@ -41,7 +41,7 @@ def make_archive(name, repo, ref, destdir):
with tmpdir() as tempdir: with tmpdir() as tempdir:
# Clone the repository to the temporary directory # Clone the repository to the temporary directory
cmd_output('git', 'clone', repo, tempdir) cmd_output('git', 'clone', repo, tempdir)
cmd_output('git', '-C', tempdir, 'checkout', ref) cmd_output('git', 'checkout', ref, cwd=tempdir)
# We don't want the '.git' directory # We don't want the '.git' directory
# It adds a bunch of size to the archive and we don't use it at # It adds a bunch of size to the archive and we don't use it at

4
pre_commit/store.py
View file

@ -144,7 +144,7 @@ class Store(object):
env = no_git_env() env = no_git_env()
def _git_cmd(*args): def _git_cmd(*args):
return cmd_output('git', '-C', directory, *args, env=env) return cmd_output('git', *args, cwd=directory, env=env)
_git_cmd('clone', '--no-checkout', repo, '.') _git_cmd('clone', '--no-checkout', repo, '.')
_git_cmd('reset', ref, '--hard') _git_cmd('reset', ref, '--hard')
@ -163,7 +163,7 @@ class Store(object):
# initialize the git repository so it looks more like cloned repos # initialize the git repository so it looks more like cloned repos
def _git_cmd(*args): def _git_cmd(*args):
cmd_output('git', '-C', directory, *args, env=env) cmd_output('git', *args, cwd=directory, env=env)
_git_cmd('init', '.') _git_cmd('init', '.')
_git_cmd('config', 'remote.origin.url', '<<unknown>>') _git_cmd('config', 'remote.origin.url', '<<unknown>>')

13
testing/fixtures.py
View file

@ -29,8 +29,8 @@ def git_dir(tempdir_factory):
def make_repo(tempdir_factory, repo_source): def make_repo(tempdir_factory, repo_source):
path = git_dir(tempdir_factory) path = git_dir(tempdir_factory)
copy_tree_to_path(get_resource_path(repo_source), path) copy_tree_to_path(get_resource_path(repo_source), path)
cmd_output('git', '-C', path, 'add', '.') cmd_output('git', 'add', '.', cwd=path)
cmd_output('git', '-C', path, 'commit', '-m', 'Add hooks') cmd_output('git', 'commit', '-m', 'Add hooks', cwd=path)
return path return path
@ -114,15 +114,14 @@ def write_config(directory, config, config_file=C.CONFIG_FILE):
def add_config_to_repo(git_path, config, config_file=C.CONFIG_FILE): def add_config_to_repo(git_path, config, config_file=C.CONFIG_FILE):
write_config(git_path, config, config_file=config_file) write_config(git_path, config, config_file=config_file)
cmd_output('git', '-C', git_path, 'add', config_file) cmd_output('git', 'add', config_file, cwd=git_path)
cmd_output('git', '-C', git_path, 'commit', '-m', 'Add hooks config') cmd_output('git', 'commit', '-m', 'Add hooks config', cwd=git_path)
return git_path return git_path
def remove_config_from_repo(git_path, config_file=C.CONFIG_FILE): def remove_config_from_repo(git_path, config_file=C.CONFIG_FILE):
os.unlink(os.path.join(git_path, config_file)) cmd_output('git', 'rm', config_file, cwd=git_path)
cmd_output('git', '-C', git_path, 'add', config_file) cmd_output('git', 'commit', '-m', 'Remove hooks config', cwd=git_path)
cmd_output('git', '-C', git_path, 'commit', '-m', 'Remove hooks config')
return git_path return git_path

19
tests/commands/autoupdate_test.py
View file

@ -62,12 +62,12 @@ def test_autoupdate_old_revision_broken(
path = make_repo(tempdir_factory, 'python_hooks_repo') path = make_repo(tempdir_factory, 'python_hooks_repo')
config = make_config_from_repo(path, check=False) config = make_config_from_repo(path, check=False)
cmd_output('git', '-C', path, 'mv', C.MANIFEST_FILE, 'nope.yaml') cmd_output('git', 'mv', C.MANIFEST_FILE, 'nope.yaml', cwd=path)
cmd_output('git', '-C', path, 'commit', '-m', 'simulate old repo') cmd_output('git', 'commit', '-m', 'simulate old repo', cwd=path)
# Assume this is the revision the user's old repository was at # Assume this is the revision the user's old repository was at
rev = git.head_rev(path) rev = git.head_rev(path)
cmd_output('git', '-C', path, 'mv', 'nope.yaml', C.MANIFEST_FILE) cmd_output('git', 'mv', 'nope.yaml', C.MANIFEST_FILE, cwd=path)
cmd_output('git', '-C', path, 'commit', '-m', 'move hooks file') cmd_output('git', 'commit', '-m', 'move hooks file', cwd=path)
update_rev = git.head_rev(path) update_rev = git.head_rev(path)
config['rev'] = rev config['rev'] = rev
@ -86,7 +86,7 @@ def out_of_date_repo(tempdir_factory):
original_rev = git.head_rev(path) original_rev = git.head_rev(path)
# Make a commit # Make a commit
cmd_output('git', '-C', path, 'commit', '--allow-empty', '-m', 'foo') cmd_output('git', 'commit', '--allow-empty', '-m', 'foo', cwd=path)
head_rev = git.head_rev(path) head_rev = git.head_rev(path)
yield auto_namedtuple( yield auto_namedtuple(
@ -221,7 +221,7 @@ def test_loses_formatting_when_not_detectable(
@pytest.fixture @pytest.fixture
def tagged_repo(out_of_date_repo): def tagged_repo(out_of_date_repo):
cmd_output('git', '-C', out_of_date_repo.path, 'tag', 'v1.2.3') cmd_output('git', 'tag', 'v1.2.3', cwd=out_of_date_repo.path)
yield out_of_date_repo yield out_of_date_repo
@ -240,8 +240,7 @@ def test_autoupdate_tagged_repo(
@pytest.fixture @pytest.fixture
def tagged_repo_with_more_commits(tagged_repo): def tagged_repo_with_more_commits(tagged_repo):
cmd = ('git', '-C', tagged_repo.path, 'commit', '--allow-empty', '-mfoo') cmd_output('git', 'commit', '--allow-empty', '-mfoo', cwd=tagged_repo.path)
cmd_output(*cmd)
yield tagged_repo yield tagged_repo
@ -268,8 +267,8 @@ def hook_disappearing_repo(tempdir_factory):
get_resource_path('manifest_without_foo.yaml'), get_resource_path('manifest_without_foo.yaml'),
os.path.join(path, C.MANIFEST_FILE), os.path.join(path, C.MANIFEST_FILE),
) )
cmd_output('git', '-C', path, 'add', '.') cmd_output('git', 'add', '.', cwd=path)
cmd_output('git', '-C', path, 'commit', '-m', 'Remove foo') cmd_output('git', 'commit', '-m', 'Remove foo', cwd=path)
yield auto_namedtuple(path=path, original_rev=original_rev) yield auto_namedtuple(path=path, original_rev=original_rev)

4
tests/commands/install_uninstall_test.py
View file

@ -161,8 +161,8 @@ def test_install_pre_commit_and_run_custom_path(tempdir_factory):
def test_install_in_submodule_and_run(tempdir_factory): def test_install_in_submodule_and_run(tempdir_factory):
src_path = make_consuming_repo(tempdir_factory, 'script_hooks_repo') src_path = make_consuming_repo(tempdir_factory, 'script_hooks_repo')
parent_path = git_dir(tempdir_factory) parent_path = git_dir(tempdir_factory)
cmd_output('git', '-C', parent_path, 'submodule', 'add', src_path, 'sub') cmd_output('git', 'submodule', 'add', src_path, 'sub', cwd=parent_path)
cmd_output('git', '-C', parent_path, 'commit', '-m', 'foo') cmd_output('git', 'commit', '-m', 'foo', cwd=parent_path)
sub_pth = os.path.join(parent_path, 'sub') sub_pth = os.path.join(parent_path, 'sub')
with cwd(sub_pth): with cwd(sub_pth):

8
tests/conftest.py
View file

@ -69,8 +69,8 @@ def _make_conflict():
def in_merge_conflict(tempdir_factory): def in_merge_conflict(tempdir_factory):
path = make_consuming_repo(tempdir_factory, 'script_hooks_repo') path = make_consuming_repo(tempdir_factory, 'script_hooks_repo')
open(os.path.join(path, 'dummy'), 'a').close() open(os.path.join(path, 'dummy'), 'a').close()
cmd_output('git', '-C', path, 'add', 'dummy') cmd_output('git', 'add', 'dummy', cwd=path)
cmd_output('git', '-C', path, 'commit', '-m', 'Add config.') cmd_output('git', 'commit', '-m', 'Add config.', cwd=path)
conflict_path = tempdir_factory.get() conflict_path = tempdir_factory.get()
cmd_output('git', 'clone', path, conflict_path) cmd_output('git', 'clone', path, conflict_path)
@ -83,8 +83,8 @@ def in_merge_conflict(tempdir_factory):
def in_conflicting_submodule(tempdir_factory): def in_conflicting_submodule(tempdir_factory):
git_dir_1 = git_dir(tempdir_factory) git_dir_1 = git_dir(tempdir_factory)
git_dir_2 = git_dir(tempdir_factory) git_dir_2 = git_dir(tempdir_factory)
cmd_output('git', '-C', git_dir_2, 'commit', '--allow-empty', '-minit!') cmd_output('git', 'commit', '--allow-empty', '-minit!', cwd=git_dir_2)
cmd_output('git', '-C', git_dir_1, 'submodule', 'add', git_dir_2, 'sub') cmd_output('git', 'submodule', 'add', git_dir_2, 'sub', cwd=git_dir_1)
with cwd(os.path.join(git_dir_1, 'sub')): with cwd(os.path.join(git_dir_1, 'sub')):
_make_conflict() _make_conflict()
yield yield

8
tests/make_archives_test.py
View file

@ -17,14 +17,14 @@ def test_make_archive(tempdir_factory):
git_path = git_dir(tempdir_factory) git_path = git_dir(tempdir_factory)
# Add a files to the git directory # Add a files to the git directory
open(os.path.join(git_path, 'foo'), 'a').close() open(os.path.join(git_path, 'foo'), 'a').close()
cmd_output('git', '-C', git_path, 'add', '.') cmd_output('git', 'add', '.', cwd=git_path)
cmd_output('git', '-C', git_path, 'commit', '-m', 'foo') cmd_output('git', 'commit', '-m', 'foo', cwd=git_path)
# We'll use this rev # We'll use this rev
head_rev = git.head_rev(git_path) head_rev = git.head_rev(git_path)
# And check that this file doesn't exist # And check that this file doesn't exist
open(os.path.join(git_path, 'bar'), 'a').close() open(os.path.join(git_path, 'bar'), 'a').close()
cmd_output('git', '-C', git_path, 'add', '.') cmd_output('git', 'add', '.', cwd=git_path)
cmd_output('git', '-C', git_path, 'commit', '-m', 'bar') cmd_output('git', 'commit', '-m', 'bar', cwd=git_path)
# Do the thing # Do the thing
archive_path = make_archives.make_archive( archive_path = make_archives.make_archive(

2
tests/staged_files_only_test.py
View file

@ -199,7 +199,7 @@ def submodule_with_commits(tempdir_factory):
def checkout_submodule(rev): def checkout_submodule(rev):
cmd_output('git', '-C', 'sub', 'checkout', rev) cmd_output('git', 'checkout', rev, cwd='sub')
@pytest.fixture @pytest.fixture