Merge pull request #553 from pre-commit/remove_legacy_hooks_yaml_support

Remove legacy 'hooks.yaml' file support

tests/manifest_test.py

@@ -60,23 +60,6 @@ def test_hooks(manifest):
     }
 
 
-def test_legacy_manifest_warn(store, tempdir_factory, log_warning_mock):
-    path = make_repo(tempdir_factory, 'legacy_hooks_yaml_repo')
-    head_sha = get_head_sha(path)
-    repo_path = store.clone(path, head_sha)
-    Manifest(repo_path, path).manifest_contents
-
-    # Should have printed a warning
-    assert log_warning_mock.call_args_list[0][0][0] == (
-        '{} uses legacy hooks.yaml to provide hooks.\n'
-        'In newer versions, this file is called .pre-commit-hooks.yaml\n'
-        'This will work in this version of pre-commit but will be removed at '
-        'a later time.\n'
-        'If `pre-commit autoupdate` does not silence this warning consider '
-        'making an issue / pull request.'.format(path)
-    )
-
-
 def test_default_python_language_version(store, tempdir_factory):
     path = make_repo(tempdir_factory, 'python_hooks_repo')
     repo_path = store.clone(path, get_head_sha(path))

tests/meta_test.py

@@ -1,9 +0,0 @@
-import io
-
-import pre_commit.constants as C
-
-
-def test_hooks_yaml_same_contents():
-    legacy_contents = io.open(C.MANIFEST_FILE_LEGACY).read()
-    contents = io.open(C.MANIFEST_FILE).read()
-    assert legacy_contents == contents

tests/repository_test.py

@@ -238,15 +238,6 @@ def test_system_hook_with_spaces(tempdir_factory, store):
     )
 
 
-@pytest.mark.integration
-def test_repo_with_legacy_hooks_yaml(tempdir_factory, store):
-    _test_hook_repo(
-        tempdir_factory, store, 'legacy_hooks_yaml_repo',
-        'system-hook-with-spaces', ['/dev/null'], b'Hello World\n',
-        config_kwargs={'legacy': True},
-    )
-
-
 @skipif_cant_run_swift
 @pytest.mark.integration
 def test_swift_hook(tempdir_factory, store):