third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-20 09:34:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Deepcopy defaults to prevent weird references in yaml.

Browse source
This commit is contained in:
Anthony Sottile 2014-04-03 21:53:31 -07:00
parent 5a7044edcc
commit 817ec510c7
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pre_commit/jsonschema_extensions.py
View file

@ -16,7 +16,9 @@ def extend_with_default(validator_class):
for property, subschema in properties.iteritems(): for property, subschema in properties.iteritems():
if "default" in subschema: if "default" in subschema:
instance.setdefault(property, subschema["default"]) instance.setdefault(
property, copy.deepcopy(subschema["default"]),
)
return jsonschema.validators.extend( return jsonschema.validators.extend(
validator_class, {"properties" : set_defaults}, validator_class, {"properties" : set_defaults},

7
tests/jsonschema_extensions_test.py
View file

@ -49,3 +49,10 @@ def test_apply_defaults_deep():
}, },
) )
assert ret == {'foo': {'bar': {'baz': 'herp'}}} assert ret == {'foo': {'bar': {'baz': 'herp'}}}
def test_apply_defaults_copies():
schema = {'properties': {'foo': {'default': []}}}
ret1 = apply_defaults({}, schema)
ret2 = apply_defaults({}, schema)
assert ret1['foo'] is not ret2['foo']