remove deprecated python_venv alias

This commit is contained in:
Anthony Sottile 2024-10-05 13:30:25 -04:00
parent a2f7b80e89
commit 801b956304
4 changed files with 0 additions and 36 deletions

View file

@ -44,7 +44,5 @@ languages: dict[str, Language] = {
'script': script, 'script': script,
'swift': swift, 'swift': swift,
'system': system, 'system': system,
# TODO: fully deprecate `python_venv`
'python_venv': python,
} }
language_names = sorted(languages) language_names = sorted(languages)

View file

@ -3,7 +3,6 @@ from __future__ import annotations
import json import json
import logging import logging
import os import os
import shlex
from collections.abc import Sequence from collections.abc import Sequence
from typing import Any from typing import Any
@ -68,14 +67,6 @@ def _hook_install(hook: Hook) -> None:
logger.info('Once installed this environment will be reused.') logger.info('Once installed this environment will be reused.')
logger.info('This may take a few minutes...') logger.info('This may take a few minutes...')
if hook.language == 'python_venv':
logger.warning(
f'`repo: {hook.src}` uses deprecated `language: python_venv`. '
f'This is an alias for `language: python`. '
f'Often `pre-commit autoupdate --repo {shlex.quote(hook.src)}` '
f'will fix this.',
)
lang = languages[hook.language] lang = languages[hook.language]
assert lang.ENVIRONMENT_DIR is not None assert lang.ENVIRONMENT_DIR is not None

View file

@ -1,7 +0,0 @@
from __future__ import annotations
from pre_commit.all_languages import languages
def test_python_venv_is_an_alias_to_python():
assert languages['python_venv'] is languages['python']

View file

@ -80,24 +80,6 @@ def _test_hook_repo(
assert out == expected assert out == expected
def test_python_venv_deprecation(store, caplog):
config = {
'repo': 'local',
'hooks': [{
'id': 'example',
'name': 'example',
'language': 'python_venv',
'entry': 'echo hi',
}],
}
_get_hook(config, store, 'example')
assert caplog.messages[-1] == (
'`repo: local` uses deprecated `language: python_venv`. '
'This is an alias for `language: python`. '
'Often `pre-commit autoupdate --repo local` will fix this.'
)
def test_system_hook_with_spaces(tempdir_factory, store): def test_system_hook_with_spaces(tempdir_factory, store):
_test_hook_repo( _test_hook_repo(
tempdir_factory, store, 'system_hook_with_spaces_repo', tempdir_factory, store, 'system_hook_with_spaces_repo',