added node hooks setup and jshint

.pre-commit-config.yaml

@@ -6,3 +6,11 @@
         -
             id: pyflakes
             files: '*.py'
+
+-
+    repo: git@github.com:pre-commit/jshint
+    sha: 191734354d1191e3771c004c3e905a94728d0349
+    hooks:
+        -
+            id: jshint
+            files: '*.js'

pre_commit/languages/helpers.py

@@ -0,0 +1,6 @@
+
+def run_hook(env, hook, file_args):
+    return env.run(
+        ' '.join([hook['entry']] + hook.get('args', []) + list(file_args)),
+        retcode=None,
+    )

pre_commit/languages/node.py

@@ -1,7 +1,40 @@
+import contextlib
+from plumbum import local
+from plumbum.machines.session import ShellSession
+from pre_commit.languages import helpers
+
+from pre_commit.languages import python
+
+NODE_ENV = 'node_env'
+
+@contextlib.contextmanager
+def in_env():
+    with ShellSession(local['bash'].popen()) as env:
+        env.run('. {0}/bin/activate'.format(NODE_ENV))
+        yield env
+
 
 def install_environment():
-    raise NotImplementedError
+    assert local.path('package.json').exists()
+
+    if local.path('node_env').exists():
+        return
+
+    # Install a virtualenv
+    local['virtualenv'][python.PY_ENV]()
+
+    with python.in_env() as python_env:
+        python_env.run('pip install nodeenv')
+
+        print "Creating nodeenv"
+        local['nodeenv'][NODE_ENV]()
+        print "Done nodeenv"
+
+        with in_env() as node_env:
+            node_env.run('npm install -g')
 
 
 def run_hook(hook, file_args):
-    raise NotImplementedError
+    with python.in_env():
+        with in_env() as node_env:
+            return helpers.run_hook(node_env, hook, file_args)

pre_commit/languages/python.py

@@ -2,6 +2,7 @@
 import contextlib
 from plumbum import local
 from plumbum.machines.session import ShellSession
+from pre_commit.languages import helpers
 
 PY_ENV = 'py_env'
 
@@ -30,7 +31,4 @@ def install_environment():
 def run_hook(hook, file_args):
     with in_env() as env:
         # TODO: batch filenames
-        return env.run(
+        return helpers.run_hook(env, hook, file_args)
-            ' '.join([hook['entry']] + hook.get('args', []) + list(file_args)),
-            retcode=None,
-        )