third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-04-16 02:21:46 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Revert "Hide passed lines in --quiet mode"

Browse source 
This reverts commit 5c1a7499cf.

Feedback from Anthony Sottile was to focus on the skipped
messages only for now.
This commit is contained in:
Peter Cock 2020-08-24 19:14:52 +01:00
parent f8c8b7ee8a
commit 7556297337
1 changed files with 9 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

24
pre_commit/commands/run.py
View file

@ -123,7 +123,6 @@ def _get_skips(environ: EnvironT) -> Set[str]:
SKIPPED = 'Skipped' SKIPPED = 'Skipped'
NO_FILES = '(no files to check)' NO_FILES = '(no files to check)'
FAILED = 'Failed'
def _subtle_line(s: str, use_color: bool) -> None: def _subtle_line(s: str, use_color: bool) -> None:
@ -177,7 +176,6 @@ def _run_single_hook(
out = b'' out = b''
else: else:
# print hook and dots first in case the hook takes a while to run # print hook and dots first in case the hook takes a while to run
if not quiet:
output.write(_start_msg(start=hook.name, end_len=6, cols=cols)) output.write(_start_msg(start=hook.name, end_len=6, cols=cols))
if not hook.pass_filenames: if not hook.pass_filenames:
@ -191,32 +189,16 @@ def _run_single_hook(
# if the hook makes changes, fail the commit # if the hook makes changes, fail the commit
files_modified = diff_before != diff_after files_modified = diff_before != diff_after
if not quiet:
# Finish the partial line of output...
if retcode or files_modified: if retcode or files_modified:
print_color = color.RED print_color = color.RED
status = FAILED status = 'Failed'
else: else:
print_color = color.GREEN print_color = color.GREEN
status = 'Passed' status = 'Passed'
output.write_line(
color.format_color(status, print_color, use_color), output.write_line(color.format_color(status, print_color, use_color))
)
if verbose or hook.verbose or retcode or files_modified: if verbose or hook.verbose or retcode or files_modified:
if quiet:
# Normal would have written this in two stages:
output.write(
_full_msg(
start=hook.name,
postfix=NO_FILES,
end_msg=FAILED,
end_color=color.RED,
use_color=use_color,
cols=cols,
),
)
_subtle_line(f'- hook id: {hook.id}', use_color) _subtle_line(f'- hook id: {hook.id}', use_color)
if (verbose or hook.verbose) and duration is not None: if (verbose or hook.verbose) and duration is not None: