mirror of
https://github.com/pre-commit/pre-commit.git
synced 2026-02-17 00:04:42 +04:00
rename system and script languages to unsupported / unsupported_script
This commit is contained in:
parent
3815e2e6d8
commit
725acc969a
9 changed files with 88 additions and 26 deletions
|
|
@ -380,6 +380,26 @@ def test_no_warning_for_non_deprecated_default_stages(caplog):
|
|||
assert caplog.record_tuples == []
|
||||
|
||||
|
||||
def test_unsupported_language_migration():
|
||||
cfg = {'repos': [sample_local_config(), sample_local_config()]}
|
||||
cfg['repos'][0]['hooks'][0]['language'] = 'system'
|
||||
cfg['repos'][1]['hooks'][0]['language'] = 'script'
|
||||
|
||||
cfgv.validate(cfg, CONFIG_SCHEMA)
|
||||
ret = cfgv.apply_defaults(cfg, CONFIG_SCHEMA)
|
||||
|
||||
assert ret['repos'][0]['hooks'][0]['language'] == 'unsupported'
|
||||
assert ret['repos'][1]['hooks'][0]['language'] == 'unsupported_script'
|
||||
|
||||
|
||||
def test_unsupported_language_migration_language_required():
|
||||
cfg = {'repos': [sample_local_config()]}
|
||||
del cfg['repos'][0]['hooks'][0]['language']
|
||||
|
||||
with pytest.raises(cfgv.ValidationError):
|
||||
cfgv.validate(cfg, CONFIG_SCHEMA)
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
'manifest_obj',
|
||||
(
|
||||
|
|
|
|||
|
|
@ -1,9 +0,0 @@
|
|||
from __future__ import annotations
|
||||
|
||||
from pre_commit.languages import system
|
||||
from testing.language_helpers import run_language
|
||||
|
||||
|
||||
def test_system_language(tmp_path):
|
||||
expected = (0, b'hello hello world\n')
|
||||
assert run_language(tmp_path, system, 'echo hello hello world') == expected
|
||||
|
|
@ -1,14 +1,14 @@
|
|||
from __future__ import annotations
|
||||
|
||||
from pre_commit.languages import script
|
||||
from pre_commit.languages import unsupported_script
|
||||
from pre_commit.util import make_executable
|
||||
from testing.language_helpers import run_language
|
||||
|
||||
|
||||
def test_script_language(tmp_path):
|
||||
def test_unsupported_script_language(tmp_path):
|
||||
exe = tmp_path.joinpath('main')
|
||||
exe.write_text('#!/usr/bin/env bash\necho hello hello world\n')
|
||||
make_executable(exe)
|
||||
|
||||
expected = (0, b'hello hello world\n')
|
||||
assert run_language(tmp_path, script, 'main') == expected
|
||||
assert run_language(tmp_path, unsupported_script, 'main') == expected
|
||||
10
tests/languages/unsupported_test.py
Normal file
10
tests/languages/unsupported_test.py
Normal file
|
|
@ -0,0 +1,10 @@
|
|||
from __future__ import annotations
|
||||
|
||||
from pre_commit.languages import unsupported
|
||||
from testing.language_helpers import run_language
|
||||
|
||||
|
||||
def test_unsupported_language(tmp_path):
|
||||
expected = (0, b'hello hello world\n')
|
||||
ret = run_language(tmp_path, unsupported, 'echo hello hello world')
|
||||
assert ret == expected
|
||||
|
|
@ -17,7 +17,7 @@ from pre_commit.clientlib import CONFIG_SCHEMA
|
|||
from pre_commit.clientlib import load_manifest
|
||||
from pre_commit.hook import Hook
|
||||
from pre_commit.languages import python
|
||||
from pre_commit.languages import system
|
||||
from pre_commit.languages import unsupported
|
||||
from pre_commit.prefix import Prefix
|
||||
from pre_commit.repository import _hook_installed
|
||||
from pre_commit.repository import all_hooks
|
||||
|
|
@ -424,7 +424,7 @@ def test_manifest_hooks(tempdir_factory, store):
|
|||
exclude_types=[],
|
||||
files='',
|
||||
id='bash_hook',
|
||||
language='script',
|
||||
language='unsupported_script',
|
||||
language_version='default',
|
||||
log_file='',
|
||||
minimum_pre_commit_version='0',
|
||||
|
|
@ -457,7 +457,7 @@ def test_non_installable_hook_error_for_language_version(store, caplog):
|
|||
'hooks': [{
|
||||
'id': 'system-hook',
|
||||
'name': 'system-hook',
|
||||
'language': 'system',
|
||||
'language': 'unsupported',
|
||||
'entry': 'python3 -c "import sys; print(sys.version)"',
|
||||
'language_version': 'python3.10',
|
||||
}],
|
||||
|
|
@ -469,7 +469,7 @@ def test_non_installable_hook_error_for_language_version(store, caplog):
|
|||
msg, = caplog.messages
|
||||
assert msg == (
|
||||
'The hook `system-hook` specifies `language_version` but is using '
|
||||
'language `system` which does not install an environment. '
|
||||
'language `unsupported` which does not install an environment. '
|
||||
'Perhaps you meant to use a specific language?'
|
||||
)
|
||||
|
||||
|
|
@ -480,7 +480,7 @@ def test_non_installable_hook_error_for_additional_dependencies(store, caplog):
|
|||
'hooks': [{
|
||||
'id': 'system-hook',
|
||||
'name': 'system-hook',
|
||||
'language': 'system',
|
||||
'language': 'unsupported',
|
||||
'entry': 'python3 -c "import sys; print(sys.version)"',
|
||||
'additional_dependencies': ['astpretty'],
|
||||
}],
|
||||
|
|
@ -492,14 +492,14 @@ def test_non_installable_hook_error_for_additional_dependencies(store, caplog):
|
|||
msg, = caplog.messages
|
||||
assert msg == (
|
||||
'The hook `system-hook` specifies `additional_dependencies` but is '
|
||||
'using language `system` which does not install an environment. '
|
||||
'using language `unsupported` which does not install an environment. '
|
||||
'Perhaps you meant to use a specific language?'
|
||||
)
|
||||
|
||||
|
||||
def test_args_with_spaces_and_quotes(tmp_path):
|
||||
ret = run_language(
|
||||
tmp_path, system,
|
||||
tmp_path, unsupported,
|
||||
f"{shlex.quote(sys.executable)} -c 'import sys; print(sys.argv[1:])'",
|
||||
('i have spaces', 'and"\'quotes', '$and !this'),
|
||||
)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue