Apply suggestions from code review

This commit is contained in:
Talia Stocks 2025-03-14 12:26:25 -04:00 committed by GitHub
parent e7959ecc5d
commit 6c87f31a79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -114,7 +114,9 @@ def _rev_exists(rev: str) -> bool:
def _is_ancestor(ancestor: str, rev: str):
return not subprocess.call(('git', 'merge-base', '--is-ancestor', ancestor, rev))
return not subprocess.call(
('git', 'merge-base', '--is-ancestor', ancestor, rev)
)
def _pre_push_ns(
@ -130,7 +132,8 @@ def _pre_push_ns(
local_branch, local_sha, remote_branch, remote_sha = parts
if local_sha == Z40:
continue
elif remote_sha != Z40 and _rev_exists(remote_sha) and _is_ancestor(remote_sha, local_sha):
elif remote_sha != Z40 and _rev_exists(remote_sha) \
and _is_ancestor(remote_sha, local_sha):
return _ns(
'pre-push', color,
from_ref=remote_sha, to_ref=local_sha,