third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-19 09:04:41 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove expected_return_value. Resolves #232

Browse source
This commit is contained in:
Anthony Sottile 2015-11-12 13:50:29 -08:00
parent 3472f2b3ce
commit 67ad0d2d8e
5 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
pre_commit/clientlib/validate_manifest.py
View file

@ -24,7 +24,6 @@ MANIFEST_JSON_SCHEMA = {
'language': {'type': 'string'}, 'language': {'type': 'string'},
'language_version': {'type': 'string', 'default': 'default'}, 'language_version': {'type': 'string', 'default': 'default'},
'files': {'type': 'string'}, 'files': {'type': 'string'},
'expected_return_value': {'type': 'number', 'default': 0},
'stages': { 'stages': {
'type': 'array', 'type': 'array',
'default': [], 'default': [],

2
pre_commit/commands/run.py
View file

@ -87,7 +87,7 @@ def _run_single_hook(hook, repo, args, write, skips=frozenset()):
retcode, stdout, stderr = repo.run_hook(hook, filenames) retcode, stdout, stderr = repo.run_hook(hook, filenames)
if retcode != hook['expected_return_value']: if retcode:
retcode = 1 retcode = 1
print_color = color.RED print_color = color.RED
pass_fail = 'Failed' pass_fail = 'Failed'

1
tests/clientlib/validate_manifest_test.py
View file

@ -77,7 +77,6 @@ def test_additional_manifest_failing(obj):
'language': 'python', 'language': 'python',
'language_version': 'python3.3', 'language_version': 'python3.3',
'files': r'\.py$', 'files': r'\.py$',
'expected_return_value': 0,
}], }],
True, True,
), ),

3
tests/commands/run_test.py
View file

@ -476,8 +476,7 @@ def test_local_hook_fails(
('hooks', [OrderedDict(( ('hooks', [OrderedDict((
('id', 'no-todo'), ('id', 'no-todo'),
('name', 'No TODO'), ('name', 'No TODO'),
('entry', 'grep -iI todo'), ('entry', 'sh -c "! grep -iI todo $@" --'),
('expected_return_value', 1),
('language', 'system'), ('language', 'system'),
('files', ''), ('files', ''),
))]) ))])

2
tests/manifest_test.py
View file

@ -23,7 +23,6 @@ def test_manifest_contents(manifest):
'description': '', 'description': '',
'entry': 'bin/hook.sh', 'entry': 'bin/hook.sh',
'exclude': '^$', 'exclude': '^$',
'expected_return_value': 0,
'files': '', 'files': '',
'id': 'bash_hook', 'id': 'bash_hook',
'language': 'script', 'language': 'script',
@ -39,7 +38,6 @@ def test_hooks(manifest):
'description': '', 'description': '',
'entry': 'bin/hook.sh', 'entry': 'bin/hook.sh',
'exclude': '^$', 'exclude': '^$',
'expected_return_value': 0,
'files': '', 'files': '',
'id': 'bash_hook', 'id': 'bash_hook',
'language': 'script', 'language': 'script',