From 662fdf26878bb56e81292f3471aab40a478c0e6e Mon Sep 17 00:00:00 2001
From: Peter Cock <p.j.a.cock@googlemail.com>
Date: Mon, 24 Aug 2020 19:19:04 +0100
Subject: [PATCH] Do not hide user-specified skipped hooks

e.g.

$ SKIP=mypy pre-commit run --files pre_commit/*.py
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check docstring is first.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Debug Statements (Python)................................................Passed
Tests should end in _test.py.........................(no files to check)Skipped
Fix requirements.txt.................................(no files to check)Skipped
Fix double quoted strings................................................Passed
flake8...................................................................Passed
autopep8.................................................................Passed
Validate Pre-Commit Manifest.........................(no files to check)Skipped
pyupgrade................................................................Passed
Reorder python imports...................................................Passed
Add trailing commas......................................................Passed
setup-cfg-fmt........................................(no files to check)Skipped
mypy....................................................................Skipped
Check hooks apply to the repository..................(no files to check)Skipped
Check for useless excludes...........................(no files to check)Skipped

Versus:

$ SKIP=mypy pre-commit run --files pre_commit/*.py -q
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check docstring is first.................................................Passed
Debug Statements (Python)................................................Passed
Fix double quoted strings................................................Passed
flake8...................................................................Passed
autopep8.................................................................Passed
pyupgrade................................................................Passed
Reorder python imports...................................................Passed
Add trailing commas......................................................Passed
mypy....................................................................Skipped

Here we still show mypy which the user had said to skip.
---
 pre_commit/commands/run.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/pre_commit/commands/run.py b/pre_commit/commands/run.py
index 3f3ddbb7..bfaa8316 100644
--- a/pre_commit/commands/run.py
+++ b/pre_commit/commands/run.py
@@ -142,16 +142,16 @@ def _run_single_hook(
     filenames = classifier.filenames_for_hook(hook)
 
     if hook.id in skips or hook.alias in skips:
-        if not quiet:
-            output.write(
-                _full_msg(
-                    start=hook.name,
-                    end_msg=SKIPPED,
-                    end_color=color.YELLOW,
-                    use_color=use_color,
-                    cols=cols,
-                ),
-            )
+        # The user specified to skip this, ignore quiet mode
+        output.write(
+            _full_msg(
+                start=hook.name,
+                end_msg=SKIPPED,
+                end_color=color.YELLOW,
+                use_color=use_color,
+                cols=cols,
+            ),
+        )
         duration = None
         retcode = 0
         diff_after = diff_before