Merge pull request #2707 from pre-commit/dart-tests

test dart directly

testing/resources/dart_repo/.pre-commit-hooks.yaml

@@ -1,4 +0,0 @@
--   id: hello-world-dart
-    name: hello world dart
-    entry: hello-world-dart
-    language: dart

testing/resources/dart_repo/bin/hello-world-dart.dart

@@ -1,6 +0,0 @@
-import 'package:ansicolor/ansicolor.dart';
-
-void main() {
-    AnsiPen pen = new AnsiPen()..red();
-    print("hello hello " + pen("world"));
-}

testing/resources/dart_repo/pubspec.yaml

@@ -1,10 +0,0 @@
-environment:
-  sdk: '>=2.10.0 <3.0.0'
-
-name: hello_world_dart
-
-executables:
-    hello-world-dart:
-
-dependencies:
-  ansicolor: ^2.0.1

tests/languages/dart_test.py

@@ -0,0 +1,62 @@
+from __future__ import annotations
+
+import re_assert
+
+from pre_commit.languages import dart
+from pre_commit.store import _make_local_repo
+from testing.language_helpers import run_language
+
+
+def test_dart(tmp_path):
+    pubspec_yaml = '''\
+environment:
+  sdk: '>=2.10.0 <3.0.0'
+
+name: hello_world_dart
+
+executables:
+    hello-world-dart:
+
+dependencies:
+  ansicolor: ^2.0.1
+'''
+    hello_world_dart_dart = '''\
+import 'package:ansicolor/ansicolor.dart';
+
+void main() {
+    AnsiPen pen = new AnsiPen()..red();
+    print("hello hello " + pen("world"));
+}
+'''
+    tmp_path.joinpath('pubspec.yaml').write_text(pubspec_yaml)
+    bin_dir = tmp_path.joinpath('bin')
+    bin_dir.mkdir()
+    bin_dir.joinpath('hello-world-dart.dart').write_text(hello_world_dart_dart)
+
+    expected = (0, b'hello hello world\n')
+    assert run_language(tmp_path, dart, 'hello-world-dart') == expected
+
+
+def test_dart_additional_deps(tmp_path):
+    _make_local_repo(str(tmp_path))
+
+    ret = run_language(
+        tmp_path,
+        dart,
+        'hello-world-dart',
+        deps=('hello_world_dart',),
+    )
+    assert ret == (0, b'hello hello world\n')
+
+
+def test_dart_additional_deps_versioned(tmp_path):
+    _make_local_repo(str(tmp_path))
+
+    ret, out = run_language(
+        tmp_path,
+        dart,
+        'secure-random -l 4 -b 16',
+        deps=('encrypt:5.0.0',),
+    )
+    assert ret == 0
+    re_assert.Matches('^[a-f0-9]{8}\n$').assert_matches(out.decode())

tests/repository_test.py

@@ -997,46 +997,6 @@ def test_dotnet_hook(tempdir_factory, store, repo):
     )
 
 
-def test_dart_hook(tempdir_factory, store):
-    _test_hook_repo(
-        tempdir_factory, store, 'dart_repo',
-        'hello-world-dart', [], b'hello hello world\n',
-    )
-
-
-def test_local_dart_additional_dependencies(store):
-    config = {
-        'repo': 'local',
-        'hooks': [{
-            'id': 'local-dart',
-            'name': 'local-dart',
-            'entry': 'hello-world-dart',
-            'language': 'dart',
-            'additional_dependencies': ['hello_world_dart'],
-        }],
-    }
-    hook = _get_hook(config, store, 'local-dart')
-    ret, out = _hook_run(hook, (), color=False)
-    assert (ret, _norm_out(out)) == (0, b'hello hello world\n')
-
-
-def test_local_dart_additional_dependencies_versioned(store):
-    config = {
-        'repo': 'local',
-        'hooks': [{
-            'id': 'local-dart',
-            'name': 'local-dart',
-            'entry': 'secure-random -l 4 -b 16',
-            'language': 'dart',
-            'additional_dependencies': ['encrypt:5.0.0'],
-        }],
-    }
-    hook = _get_hook(config, store, 'local-dart')
-    ret, out = _hook_run(hook, (), color=False)
-    assert ret == 0
-    re_assert.Matches('^[a-f0-9]{8}\r?\n$').assert_matches(out.decode())
-
-
 def test_non_installable_hook_error_for_language_version(store, caplog):
     config = {
         'repo': 'local',