third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

When possible, preserve config format on autoupdate

Browse source
This commit is contained in:
Anthony Sottile 2017-08-10 17:57:53 -07:00
parent 72efbb3950
commit 59c6df5e46
2 changed files with 96 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

56
tests/commands/autoupdate_test.py
View file

@ -1,5 +1,6 @@
from __future__ import unicode_literals
import pipes
import shutil
from collections import OrderedDict
@ -123,6 +124,61 @@ def test_autoupdate_out_of_date_repo(
assert out_of_date_repo.head_sha in after
def test_does_not_reformat(
out_of_date_repo, mock_out_store_directory, in_tmpdir,
):
fmt = (
'- repo: {}\n'
' sha: {} # definitely the version I want!\n'
' hooks:\n'
' - id: foo\n'
' # These args are because reasons!\n'
' args: [foo, bar, baz]\n'
)
config = fmt.format(out_of_date_repo.path, out_of_date_repo.original_sha)
with open(C.CONFIG_FILE, 'w') as f:
f.write(config)
autoupdate(Runner('.', C.CONFIG_FILE), tags_only=False)
after = open(C.CONFIG_FILE).read()
expected = fmt.format(out_of_date_repo.path, out_of_date_repo.head_sha)
assert after == expected
def test_loses_formatting_when_not_detectable(
out_of_date_repo, mock_out_store_directory, in_tmpdir,
):
"""A best-effort attempt is made at updating sha without rewriting
formatting. When the original formatting cannot be detected, this
is abandoned.
"""
config = (
'[\n'
' {{\n'
' repo: {}, sha: {},\n'
' hooks: [\n'
' # A comment!\n'
' {{id: foo}},\n'
' ],\n'
' }}\n'
']\n'.format(
pipes.quote(out_of_date_repo.path), out_of_date_repo.original_sha,
)
)
with open(C.CONFIG_FILE, 'w') as f:
f.write(config)
autoupdate(Runner('.', C.CONFIG_FILE), tags_only=False)
after = open(C.CONFIG_FILE).read()
expected = (
'- repo: {}\n'
' sha: {}\n'
' hooks:\n'
' - id: foo\n'
).format(out_of_date_repo.path, out_of_date_repo.head_sha)
assert after == expected
@pytest.yield_fixture
def tagged_repo(out_of_date_repo):
with cwd(out_of_date_repo.path):