From 4f58f119b1a63b19fbff736d68f57bf84c02bcba Mon Sep 17 00:00:00 2001 From: Anthony Sottile Date: Tue, 22 Dec 2015 12:33:17 -0800 Subject: [PATCH] Add regression test for `always_run` setting --- tests/commands/run_test.py | 6 ++++++ tests/manifest_test.py | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/commands/run_test.py b/tests/commands/run_test.py index 120dce2a..a0795f28 100644 --- a/tests/commands/run_test.py +++ b/tests/commands/run_test.py @@ -184,6 +184,12 @@ def test_run( _test_run(repo_with_passing_hook, options, outputs, expected_ret, stage) +def test_always_run(repo_with_passing_hook, mock_out_store_directory): + with modify_config() as config: + config[0]['hooks'][0]['always_run'] = True + _test_run(repo_with_passing_hook, {}, (b'Bash hook', b'Passed'), 0, False) + + @pytest.mark.parametrize( ('origin', 'source', 'expect_failure'), ( diff --git a/tests/manifest_test.py b/tests/manifest_test.py index ffd3b390..174f201f 100644 --- a/tests/manifest_test.py +++ b/tests/manifest_test.py @@ -19,6 +19,7 @@ def manifest(store, tempdir_factory): def test_manifest_contents(manifest): # Should just retrieve the manifest contents assert manifest.manifest_contents == [{ + 'always_run': False, 'args': [], 'description': '', 'entry': 'bin/hook.sh', @@ -30,12 +31,12 @@ def test_manifest_contents(manifest): 'minimum_pre_commit_version': '0.0.0', 'name': 'Bash hook', 'stages': [], - 'always_run': False }] def test_hooks(manifest): assert manifest.hooks['bash_hook'] == { + 'always_run': False, 'args': [], 'description': '', 'entry': 'bin/hook.sh', @@ -47,5 +48,4 @@ def test_hooks(manifest): 'minimum_pre_commit_version': '0.0.0', 'name': 'Bash hook', 'stages': [], - 'always_run': False }