third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 00:04:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #852 from pre-commit/install_only_once

Browse source 
Install multi-hook repositories only once
This commit is contained in:
Anthony Sottile 2018-10-23 10:47:22 -07:00 • committed by GitHub
commit 47e4f39436
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pre_commit/prefix.py
View file

@ -1,11 +1,11 @@
from __future__ import unicode_literals
import collections
import os.path
class Prefix(object):
def __init__(self, prefix_dir):
self.prefix_dir = prefix_dir
class Prefix(collections.namedtuple('Prefix', ('prefix_dir',))):
__slots__ = ()
def path(self, *parts):
return os.path.normpath(os.path.join(self.prefix_dir, *parts))

6
pre_commit/repository.py
View file

@ -179,12 +179,12 @@ class Repository(object):
return Prefix(self.store.clone(repo, rev, deps))
def _venvs(self):
ret = []
ret = set()
for _, hook in self.hooks:
language = hook['language']
version = hook['language_version']
deps = hook['additional_dependencies']
ret.append((
deps = tuple(hook['additional_dependencies'])
ret.add((
self._prefix_from_deps(language, deps),
language, version, deps,
))

6
tests/repository_test.py
View file

@ -466,7 +466,7 @@ def test_venvs(tempdir_factory, store):
config = make_config_from_repo(path)
repo = Repository.create(config, store)
venv, = repo._venvs()
assert venv == (mock.ANY, 'python', python.get_default_version(), [])
assert venv == (mock.ANY, 'python', python.get_default_version(), ())
def test_additional_dependencies(tempdir_factory, store):
@ -474,8 +474,8 @@ def test_additional_dependencies(tempdir_factory, store):
config = make_config_from_repo(path)
config['hooks'][0]['additional_dependencies'] = ['pep8']
repo = Repository.create(config, store)
venv, = repo._venvs()
assert venv == (mock.ANY, 'python', python.get_default_version(), ['pep8'])
env, = repo._venvs()
assert env == (mock.ANY, 'python', python.get_default_version(), ('pep8',))
def test_additional_dependencies_roll_forward(tempdir_factory, store):