third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-04-16 02:21:46 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Permit installing to core.hooksPath if within repo

Browse source 
### Summary

There's [several
threads](https://github.com/pre-commit/pre-commit/issues?q=is%3Aissue+core+hooksPath+is%3Aclosed)
around using pre-commit with global git hooks directories, but I didn't
see anything around setting `core.hooksPath` to a directory within the
repo, as the `husky` tool does.

This patch adds support for installing/uninstalling pre-commit when
`core.hooksPath` references a path within the git repo.

 ### Testing

- add a couple of simple tests
- a repo with core.hooksPath set within the repo, install/uninstall does
  the right thing
- a repo with core.hooksPath set to `../hooks`, install/uninstall fails
- a repo with core.hooksPath unset, install/uninstall works as before
This commit is contained in:
Noah Pendleton 2021-08-05 13:02:19 -04:00
parent 6cfdabb69a
commit 451e042835
3 changed files with 51 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/commands/install_uninstall_test.py
View file

@ -105,9 +105,18 @@ def test_install_multiple_hooks_at_once(in_git_dir, store):
assert not in_git_dir.join('.git/hooks/pre-push').exists()
def test_install_refuses_core_hookspath(in_git_dir, store):
cmd_output('git', 'config', '--local', 'core.hooksPath', 'hooks')
def test_install_refuses_core_hookspath_outside_repo(in_git_dir, store):
cmd_output('git', 'config', '--local', 'core.hooksPath', '../hooks')
assert install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
cmd_output('git', 'config', '--local', 'core.hooksPath', '/tmp/hooks')
assert install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
def test_install_core_hookspath_inside_repo(in_git_dir, store):
hook = in_git_dir.join('.hooks').ensure_dir().join('pre-commit')
cmd_output('git', 'config', '--local', 'core.hooksPath', '.hooks')
install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
assert hook.exists()
def test_install_hooks_dead_symlink(in_git_dir, store):