third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-04-16 02:21:46 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

some updates and fixes

Browse source 
Didn't get around to it in my previous attempt, so doing it now.
 - updated deprecated .warn() to .warning()
 - unnecessary f-strings
 - imported sys to allow sys.exit calls instead of exit
 - simplified some not checks
 - replaced type with isinstance
 -
This commit is contained in:
Mark Mayo 2023-04-17 12:02:39 +12:00
parent 6896025288
commit 43e9a86394
5 changed files with 25 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

31
pre_commit/repository.py
View file

@ -3,6 +3,7 @@ from __future__ import annotations
import json
import logging
import os
import sys
import shlex
from typing import Any
from typing import Sequence
@ -72,9 +73,9 @@ def _hook_install(hook: Hook) -> None:
if hook.language == 'python_venv':
logger.warning(
f'`repo: {hook.src}` uses deprecated `language: python_venv`. '
f'This is an alias for `language: python`. '
'This is an alias for `language: python`. '
f'Often `pre-commit autoupdate --repo {shlex.quote(hook.src)}` '
f'will fix this.',
'will fix this.',
)
lang = languages[hook.language]
@ -99,8 +100,8 @@ def _hook_install(hook: Hook) -> None:
if health_error:
raise AssertionError(
f'BUG: expected environment for {hook.language} to be healthy '
f'immediately after install, please open an issue describing '
f'your environment\n\n'
'immediately after install, please open an issue describing '
'your environment\n\n'
f'more info:\n\n{health_error}',
)
@ -129,9 +130,9 @@ def _hook(
logger.error(
f'The hook `{ret["id"]}` requires pre-commit version {version} '
f'but version {C.VERSION} is installed. '
f'Perhaps run `pip install --upgrade pre-commit`.',
'Perhaps run `pip install --upgrade pre-commit`.',
)
exit(1)
sys.exit(1)
lang = ret['language']
if ret['language_version'] == C.DEFAULT:
@ -147,18 +148,18 @@ def _hook(
logger.error(
f'The hook `{ret["id"]}` specifies `language_version` but is '
f'using language `{lang}` which does not install an '
f'environment. '
f'Perhaps you meant to use a specific language?',
'environment. '
'Perhaps you meant to use a specific language?',
)
exit(1)
sys.exit(1)
if ret['additional_dependencies']:
logger.error(
f'The hook `{ret["id"]}` specifies `additional_dependencies` '
f'but is using language `{lang}` which does not install an '
f'environment. '
f'Perhaps you meant to use a specific language?',
'environment. '
'Perhaps you meant to use a specific language?',
)
exit(1)
sys.exit(1)
return ret
@ -200,10 +201,10 @@ def _cloned_repository_hooks(
if hook['id'] not in by_id:
logger.error(
f'`{hook["id"]}` is not present in repository {repo}. '
f'Typo? Perhaps it is introduced in a newer version? '
f'Often `pre-commit autoupdate` fixes this.',
'Typo? Perhaps it is introduced in a newer version? '
'Often `pre-commit autoupdate` fixes this.',
)
exit(1)
sys.exit(1)
hook_dcts = [
_hook(by_id[hook['id']], hook, root_config=root_config)