third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

A more reliable way to get the container id.

Browse source 
The hostname is not always the container id. Get the container id from
/proc/1/cgroup. Fixes #1918.
This commit is contained in:
Adar Nimrod 2021-05-22 13:13:33 +03:00 • committed by Anthony Sottile
parent 68294256a1
commit 3e1020945e
2 changed files with 65 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

17
pre_commit/languages/docker.py
View file

@ -1,7 +1,6 @@
import hashlib
import json
import os
import socket
from typing import Sequence
from typing import Tuple
@ -26,12 +25,24 @@ def _is_in_docker() -> bool:
return False
def _get_container_id() -> str:
# It's assumed that we already check /proc/1/cgroup in _is_in_docker. The
# cpuset cgroup controller existed since cgroups were introduced so this
# way of getting the container ID is pretty reliable.
with open('/proc/1/cgroup', 'rb') as f:
for line in f.readlines():
if line.split(b':')[1] == b'cpuset':
return os.path.basename(line.split(b':')[2]).strip().decode()
raise RuntimeError('Failed to find the container ID in /proc/1/cgroup.')
def _get_docker_path(path: str) -> str:
if not _is_in_docker():
return path
hostname = socket.gethostname()
_, out, _ = cmd_output_b('docker', 'inspect', hostname)
container_id = _get_container_id()
_, out, _ = cmd_output_b('docker', 'inspect', container_id)
container, = json.loads(out)
for mount in container['Mounts']: