Add types to pre-commit

tests/languages/all_test.py

@@ -1,23 +1,31 @@
-import functools
 import inspect
+from typing import Sequence
+from typing import Tuple
 
 import pytest
 
 from pre_commit.languages.all import all_languages
 from pre_commit.languages.all import languages
+from pre_commit.prefix import Prefix
 
 
-ArgSpec = functools.partial(
-    inspect.FullArgSpec, varargs=None, varkw=None, defaults=None,
-    kwonlyargs=[], kwonlydefaults=None, annotations={},
-)
+def _argspec(annotations):
+    args = [k for k in annotations if k != 'return']
+    return inspect.FullArgSpec(
+        args=args, annotations=annotations,
+        varargs=None, varkw=None, defaults=None,
+        kwonlyargs=[], kwonlydefaults=None,
+    )
 
 
 @pytest.mark.parametrize('language', all_languages)
 def test_install_environment_argspec(language):
-    expected_argspec = ArgSpec(
-        args=['prefix', 'version', 'additional_dependencies'],
-    )
+    expected_argspec = _argspec({
+        'return': None,
+        'prefix': Prefix,
+        'version': str,
+        'additional_dependencies': Sequence[str],
+    })
     argspec = inspect.getfullargspec(languages[language].install_environment)
     assert argspec == expected_argspec
 
@@ -29,20 +37,26 @@ def test_ENVIRONMENT_DIR(language):
 
 @pytest.mark.parametrize('language', all_languages)
 def test_run_hook_argspec(language):
-    expected_argspec = ArgSpec(args=['hook', 'file_args', 'color'])
+    expected_argspec = _argspec({
+        'return': Tuple[int, bytes],
+        'hook': 'Hook', 'file_args': Sequence[str], 'color': bool,
+    })
     argspec = inspect.getfullargspec(languages[language].run_hook)
     assert argspec == expected_argspec
 
 
 @pytest.mark.parametrize('language', all_languages)
 def test_get_default_version_argspec(language):
-    expected_argspec = ArgSpec(args=[])
+    expected_argspec = _argspec({'return': str})
     argspec = inspect.getfullargspec(languages[language].get_default_version)
     assert argspec == expected_argspec
 
 
 @pytest.mark.parametrize('language', all_languages)
 def test_healthy_argspec(language):
-    expected_argspec = ArgSpec(args=['prefix', 'language_version'])
+    expected_argspec = _argspec({
+        'return': bool,
+        'prefix': Prefix, 'language_version': str,
+    })
     argspec = inspect.getfullargspec(languages[language].healthy)
     assert argspec == expected_argspec

tests/languages/docker_test.py

@@ -7,7 +7,7 @@ from pre_commit.util import CalledProcessError
 def test_docker_is_running_process_error():
     with mock.patch(
         'pre_commit.languages.docker.cmd_output_b',
-        side_effect=CalledProcessError(None, None, None, None, None),
+        side_effect=CalledProcessError(1, (), 0, b'', None),
     ):
         assert docker.docker_is_running() is False
 

tests/languages/helpers_test.py

@@ -17,7 +17,7 @@ def test_basic_get_default_version():
 
 
 def test_basic_healthy():
-    assert helpers.basic_healthy(None, None) is True
+    assert helpers.basic_healthy(Prefix('.'), 'default') is True
 
 
 def test_failed_setup_command_does_not_unicode_error():
@@ -77,4 +77,6 @@ def test_target_concurrency_cpu_count_not_implemented():
 
 
 def test_shuffled_is_deterministic():
-    assert helpers._shuffled(range(10)) == [3, 7, 8, 2, 4, 6, 5, 1, 0, 9]
+    seq = [str(i) for i in range(10)]
+    expected = ['3', '7', '8', '2', '4', '6', '5', '1', '0', '9']
+    assert helpers._shuffled(seq) == expected