Merge pull request #137 from pre-commit/install_before_running

Install hooks before attempting to run anything

pre_commit/runner.py

@@ -37,7 +37,10 @@ class Runner(object):
     def repositories(self):
         """Returns a tuple of the configured repositories."""
         config = load_config(self.config_file_path)
-        return tuple(Repository.create(x, self.store) for x in config)
+        repositories = tuple(Repository.create(x, self.store) for x in config)
+        for repository in repositories:
+            repository.require_installed()
+        return repositories
 
     @cached_property
     def pre_commit_path(self):

testing/resources/consumer_repo/.pre-commit-config.yaml

@@ -1,13 +0,0 @@
--   repo: git@github.com:pre-commit/pre-commit-hooks
-    sha: bec87f6c87284ea15dbcf7801810404c8036bab4
-    hooks:
-    -   id: pyflakes
-    -   id: debug-statements
-    -   id: trailing-whitespace
-    -   id: name-tests-test
-    -   id: end-of-file-fixer
--   repo: git@github.com:pre-commit/pre-commit
-    sha: c62c1a3b513ab9e057e85a5e950bd7c438371076
-    hooks:
-    -   id: validate_manifest
-    -   id: validate_config

tests/runner_test.py

@@ -8,7 +8,7 @@ from plumbum import local
 import pre_commit.constants as C
 from pre_commit.runner import Runner
 from testing.fixtures import git_dir
-from testing.fixtures import make_repo
+from testing.fixtures import make_consuming_repo
 
 
 def test_init_has_no_side_effects(tmpdir):
@@ -47,14 +47,9 @@ def test_config_file_path():
 
 
 def test_repositories(tmpdir_factory, mock_out_store_directory):
-    # TODO: make this not have external deps
+    path = make_consuming_repo(tmpdir_factory, 'script_hooks_repo')
-    path = make_repo(tmpdir_factory, 'consumer_repo')
     runner = Runner(path)
-    assert len(runner.repositories) == 2
+    assert len(runner.repositories) == 1
-    assert [repo.repo_url for repo in runner.repositories] == [
-        'git@github.com:pre-commit/pre-commit-hooks',
-        'git@github.com:pre-commit/pre-commit',
-    ]
 
 
 def test_pre_commit_path():