third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix xargs.partition: use sys.getfilesystemencoding

Browse source 
The previous `sys.getdefaultencoding` almost always fallsback to
`ascii` while `sys.getfilesystemencoding` is utf-8 once in utf-8 mode.
This commit is contained in:
George Y. Kussumoto 2018-10-05 16:39:49 -03:00
parent df5d171cd7
commit 2ad69e12ce
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pre_commit/xargs.py
View file

@ -22,7 +22,7 @@ def _get_command_length(command, arg):
if sys.platform == 'win32': if sys.platform == 'win32':
return len(full_cmd) return len(full_cmd)
return len(full_cmd.encode(sys.getdefaultencoding())) return len(full_cmd.encode(sys.getfilesystemencoding()))
class ArgumentTooLongError(RuntimeError): class ArgumentTooLongError(RuntimeError):

4
tests/xargs_test.py
View file

@ -11,7 +11,7 @@ from pre_commit import xargs
def sys_win32_mock(mocker): def sys_win32_mock(mocker):
return mocker.Mock( return mocker.Mock(
platform='win32', platform='win32',
getdefaultencoding=mocker.Mock(return_value='utf-8'), getfilesystemencoding=mocker.Mock(return_value='utf-8'),
) )
@ -19,7 +19,7 @@ def sys_win32_mock(mocker):
def sys_linux_mock(mocker): def sys_linux_mock(mocker):
return mocker.Mock( return mocker.Mock(
platform='linux', platform='linux',
getdefaultencoding=mocker.Mock(return_value='utf-8'), getfilesystemencoding=mocker.Mock(return_value='utf-8'),
) )