third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add support for Rust CLI dependencies

Browse source 
Also consistently build the hook using `cargo install`.
This commit is contained in:
Chris Kuehl 2018-05-21 22:02:03 -07:00
parent 7f85da1b9d
commit 2a37fcd3fe
1 changed files with 24 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

32
pre_commit/languages/rust.py
View file

@ -22,7 +22,7 @@ def get_env_patch(target_dir):
return ( return (
( (
'PATH', 'PATH',
(os.path.join(target_dir, 'release'), os.pathsep, Var('PATH')), (os.path.join(target_dir, 'bin'), os.pathsep, Var('PATH')),
), ),
) )
@ -47,20 +47,36 @@ def _add_dependencies(cargo_toml_path, additional_dependencies):
f.truncate() f.truncate()
def install_environment(prefix, version, additional_dependencies): def install_environment(prefix, version, additional_deps):
helpers.assert_version_default('rust', version) helpers.assert_version_default('rust', version)
directory = prefix.path( directory = prefix.path(
helpers.environment_dir(ENVIRONMENT_DIR, 'default'), helpers.environment_dir(ENVIRONMENT_DIR, 'default'),
) )
if len(additional_dependencies) > 0: # There are two cases where we might want to specify more dependencies:
_add_dependencies(prefix.path('Cargo.toml'), additional_dependencies) # as dependencies for the library being built, and as binary packages
# to be `cargo install`'d.
#
# Unlike e.g. Python, if we just `cargo install` a library, it won't be
# used for compilation. And if we add a crate providing a binary to the
# `Cargo.toml`, the binary won't be built.
#
# Because of this, we allow specifying "cli" dependencies by prefixing
# with 'cli:'.
cli_deps = {dep for dep in additional_deps if dep.startswith('cli:')}
lib_deps = set(additional_deps) - cli_deps
if len(lib_deps) > 0:
_add_dependencies(prefix.path('Cargo.toml'), lib_deps)
with clean_path_on_failure(directory): with clean_path_on_failure(directory):
cmd_output( packages_to_install = {()} | {(dep[len('cli:'):],) for dep in cli_deps}
'cargo', 'build', '--release', '--bins', '--target-dir', directory,
cwd=prefix.prefix_dir, for package in packages_to_install:
) cmd_output(
'cargo', 'install', '--bins', '--root', directory, *package,
cwd=prefix.prefix_dir
)
def run_hook(prefix, hook, file_args): def run_hook(prefix, hook, file_args):