third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-04-16 18:41:46 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #1000

Browse source
This commit is contained in:
Ross Jacobs 2019-04-20 00:16:30 +01:00
parent 809b7482df
commit 2079ff7482
No known key found for this signature in database
GPG key ID: 2AC7B747EEF4960F
1 changed files with 32 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

38
pre_commit/xargs.py
View file

@ -53,11 +53,37 @@ class ArgumentTooLongError(RuntimeError):
pass pass
def partition(cmd, varargs, target_concurrency, _max_length=None): def infix_vararg(cmd, vararg):
_max_length = _max_length or _get_platform_max_length() """Insert vararg before --, if it is not the last elem of the command
# Generally, we try to partition evenly into at least `target_concurrency` This is required because if vararg comes after --, then the command will
# partitions, but we don't want a bunch of tiny partitions. skip vararg as an option, which is undesired behavior.
Args:
cmd (tuple): Contents of `entry:` + `args:`
vararg (list): A file that meets criteria for analysis for `entry:`
Returns (tuple):
current partition using vararg
"""
if '--' in cmd[:-1]:
opts_end = cmd.index('--')
cmds = cmd[:opts_end] + tuple(vararg) + cmd[opts_end:]
else:
cmds = cmd + tuple(vararg)
return tuple(cmds)
def partition(cmd, varargs, target_concurrency, _max_length=None):
"""Create partitions with cmd and vararg.
Generally, we try to partition evenly into at least `target_concurrency`
partitions, but we don't want a bunch of tiny partitions.
Returns (list):
List of partitions like [($cmd $vararg <options>...), ...]
"""
_max_length = _max_length or _get_platform_max_length()
max_args = max(4, math.ceil(len(varargs) / target_concurrency)) max_args = max(4, math.ceil(len(varargs) / target_concurrency))
cmd = tuple(cmd) cmd = tuple(cmd)
@ -82,12 +108,12 @@ def partition(cmd, varargs, target_concurrency, _max_length=None):
raise ArgumentTooLongError(arg) raise ArgumentTooLongError(arg)
else: else:
# We've exceeded the length, yield a command # We've exceeded the length, yield a command
ret.append(cmd + tuple(ret_cmd)) ret.append(infix_vararg(cmd, ret_cmd))
ret_cmd = [] ret_cmd = []
total_length = _command_length(*cmd) + 1 total_length = _command_length(*cmd) + 1
varargs.append(arg) varargs.append(arg)
ret.append(cmd + tuple(ret_cmd)) ret.append(infix_vararg(cmd, ret_cmd))
return tuple(ret) return tuple(ret)