third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix check-useless-exclude to consider types filter

Browse source
This commit is contained in:
George Y. Kussumoto 2018-10-02 12:17:46 -03:00
parent 08319101f4
commit 1b496c5fc3
2 changed files with 35 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
pre_commit/meta_hooks/check_useless_excludes.py
View file

@ -9,6 +9,7 @@ import pre_commit.constants as C
from pre_commit import git
from pre_commit.clientlib import load_config
from pre_commit.clientlib import MANIFEST_HOOK_DICT
from pre_commit.commands.run import _filter_by_types
def exclude_matches_any(filenames, include, exclude):
@ -39,8 +40,10 @@ def check_useless_excludes(config_file):
# Not actually a manifest dict, but this more accurately reflects
# the defaults applied during runtime
hook = apply_defaults(hook, MANIFEST_HOOK_DICT)
types, exclude_types = hook['types'], hook['exclude_types']
filtered_by_types = _filter_by_types(files, types, exclude_types)
include, exclude = hook['files'], hook['exclude']
if not exclude_matches_any(files, include, exclude):
if not exclude_matches_any(filtered_by_types, include, exclude):
print(
'The exclude pattern {!r} for {} does not match any files'
.format(exclude, hook['id']),