third-party/pre-commit
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit.git synced 2026-02-17 08:14:42 +04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Some minor constants cleanup

Browse source
This commit is contained in:
Anthony Sottile 2017-02-16 10:44:08 -08:00
parent b32facc5b3
commit 109c17c5df
3 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pre_commit/constants.py
View file

@ -1,5 +1,6 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import pkg_resources
CONFIG_FILE = '.pre-commit-config.yaml' CONFIG_FILE = '.pre-commit-config.yaml'
@ -13,3 +14,9 @@ YAML_DUMP_KWARGS = {
'encoding': None, 'encoding': None,
'indent': 4, 'indent': 4,
} }
# Bump when installation changes in a backwards / forwards incompatible way
INSTALLED_STATE_VERSION = '1'
VERSION = pkg_resources.get_distribution('pre-commit').version
VERSION_PARSED = pkg_resources.parse_version(VERSION)

7
pre_commit/main.py
View file

@ -4,8 +4,7 @@ import argparse
import os import os
import sys import sys
import pkg_resources import pre_commit.constants as C
from pre_commit import color from pre_commit import color
from pre_commit import five from pre_commit import five
from pre_commit import git from pre_commit import git
@ -51,9 +50,7 @@ def main(argv=None):
parser.add_argument( parser.add_argument(
'-V', '--version', '-V', '--version',
action='version', action='version',
version='%(prog)s {}'.format( version='%(prog)s {}'.format(C.VERSION),
pkg_resources.get_distribution('pre-commit').version
)
) )
subparsers = parser.add_subparsers(dest='command') subparsers = parser.add_subparsers(dest='command')

16
pre_commit/repository.py
View file

@ -10,6 +10,7 @@ from collections import defaultdict
import pkg_resources import pkg_resources
from cached_property import cached_property from cached_property import cached_property
import pre_commit.constants as C
from pre_commit import five from pre_commit import five
from pre_commit import git from pre_commit import git
from pre_commit.clientlib.validate_config import is_local_hooks from pre_commit.clientlib.validate_config import is_local_hooks
@ -23,20 +24,15 @@ from pre_commit.prefixed_command_runner import PrefixedCommandRunner
logger = logging.getLogger('pre_commit') logger = logging.getLogger('pre_commit')
_pre_commit_version = pkg_resources.parse_version(
pkg_resources.get_distribution('pre-commit').version
)
# Bump when installation changes in a backwards / forwards incompatible way
INSTALLED_STATE_VERSION = '1'
def _state(additional_deps): def _state(additional_deps):
return {'additional_dependencies': sorted(additional_deps)} return {'additional_dependencies': sorted(additional_deps)}
def _state_filename(cmd_runner, venv): def _state_filename(cmd_runner, venv):
return cmd_runner.path(venv, '.install_state_v' + INSTALLED_STATE_VERSION) return cmd_runner.path(
venv, '.install_state_v' + C.INSTALLED_STATE_VERSION,
)
def _read_installed_state(cmd_runner, venv): def _read_installed_state(cmd_runner, venv):
@ -140,12 +136,12 @@ class Repository(object):
hook_version = pkg_resources.parse_version( hook_version = pkg_resources.parse_version(
self.manifest.hooks[hook['id']]['minimum_pre_commit_version'], self.manifest.hooks[hook['id']]['minimum_pre_commit_version'],
) )
if hook_version > _pre_commit_version: if hook_version > C.VERSION_PARSED:
logger.error( logger.error(
'The hook `{}` requires pre-commit version {} but ' 'The hook `{}` requires pre-commit version {} but '
'version {} is installed. ' 'version {} is installed. '
'Perhaps run `pip install --upgrade pre-commit`.'.format( 'Perhaps run `pip install --upgrade pre-commit`.'.format(
hook['id'], hook_version, _pre_commit_version, hook['id'], hook_version, C.VERSION_PARSED,
) )
) )
exit(1) exit(1)